[codex] Improve extractor hot path performance - #3607
Merged
Conversation
Widthdom
marked this pull request as ready for review
June 13, 2026 07:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Large generated files could trigger super-linear extraction work when supplemental extractors repeatedly scanned already accumulated references, symbols, or scan targets while processing each new candidate. The observed severe regression was in C# reference extraction; the follow-up audit found similar theoretical hot paths in several non-C# symbol/reference extractors.
Validation
dotnet build src/CodeIndex/CodeIndex.csproj --no-restore -p:UseSharedCompilation=false -m:1 -v:minimaldotnet build tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-restore -p:UseSharedCompilation=false -m:1 -v:minimaldotnet run --project tools/CodeIndex.Changelog -- checkgit diff --checkcdidx index ... --jsonsymbols.Any,symbols.First,targets.Any,references.Any, orreferences.Firsthot-path matches in extractor code.Note:
dotnet testcould not run in this environment because VSTest/MSBuild socket or pipe creation failed withPermission denied; targeted tests were run through the reflection harness instead.