Fix trusted executable resolution for git and worker hosts - #3610
Merged
Conversation
# Conflicts: # src/CodeIndex/Indexer/Hooks/PostExtractionHookCallbackWorker.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/usr/bin/gitdeveloper-tools shim.dotnet; isolated symbol and hook workers now require a trusted absolute dotnet host path from the current process or standard system install candidates, and fail with a structured diagnostic when one cannot be resolved.Validation
dotnet build CodeIndex.sln -c Debug -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Debug --no-build --filter FullyQualifiedName~GitHelperTestsdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Debug --no-build --filter StartInfodotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Debug --no-build --filter DotnetHostPathResolverdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Debug --no-build --filter FullyQualifiedName~PostExtractionHookdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Debug --no-build --filter FullyQualifiedName~SymbolExtractionWorkerdotnet test --no-build --filter "FullyQualifiedName~Issue3433|FullyQualifiedName~Issue3455"dotnet run --project tools/CodeIndex.Changelog -- checkgit diff --checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --jsondotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json/usr/bin/gitshim risk, fixed it, then reran withNo blocking/actionable issues found.Full suite note: full
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Debug --no-buildpassed earlier in this branch before the final trusted-path candidate tightening; the final smaller changes were revalidated with the targeted tests and build above.Fixes #3433
Fixes #3455