Skip to content

[codex] Harden PackageNormalize ZIP handling - #3613

Merged
Widthdom merged 2 commits into
mainfrom
fix-issue3552-3458
Jun 13, 2026
Merged

[codex] Harden PackageNormalize ZIP handling#3613
Widthdom merged 2 commits into
mainfrom
fix-issue3552-3458

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Harden PackageNormalize ZIP entry attribute handling by rejecting unsafe POSIX/DOS metadata and scrubbing destination external attributes.
  • Bound and sanitize PackageNormalize failure diagnostics, cap package arguments, and report cleanup deletion failures as per-package JSON warnings.
  • Document the normalizer safety and diagnostics contracts in both English and Japanese sections.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~ReleaseWorkflowTests -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --filter FullyQualifiedName~ReleaseWorkflowTests -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet build CodeIndex.sln -p:UseSharedCompilation=false
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json

Documentation and Changelog

  • Updated DEVELOPER_GUIDE.md in English and Japanese.
  • Added changelog.d/unreleased/3552.fixed.md.
  • Added changelog.d/unreleased/3458.fixed.md.

Adversarial Review

No blocking/actionable issues found.

Follow-up Candidates

None.

Fixes #3552
Fixes #3458

@Widthdom
Widthdom marked this pull request as ready for review June 13, 2026 15:57
@Widthdom
Widthdom merged commit 43d4b9c into main Jun 13, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3552-3458 branch June 14, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant