Skip to content

Isolate worker hooks and proxy credentials - #3614

Merged
Widthdom merged 2 commits into
mainfrom
fix-issue3398-3369
Jun 13, 2026
Merged

Isolate worker hooks and proxy credentials#3614
Widthdom merged 2 commits into
mainfrom
fix-issue3398-3369

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Isolate symbol extraction worker test controls from ambient environment variables and remove the worker completion-path write.
  • Gate default OS proxy credential forwarding for GitHub issue submission and duplicate preflight behind an explicit opt-in environment variable.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~IndexCommandRunnerTests|FullyQualifiedName~GitHubIssueReporterTests|FullyQualifiedName~IssueDuplicatePreflightTests" -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~SymbolExtractionWorker_TimeoutKillsWorkerBeforeDelayedExtractionContinues|FullyQualifiedName~SymbolExtractionWorker_LegacyEnvironmentHooksAreIgnored_Issue3398|FullyQualifiedName~SymbolExtractionWorker_CapturesStdoutAndForwardsStderrDiagnostics|FullyQualifiedName~SymbolExtractionWorker_StartInfo_BoundsInternalTestDelay_Issue3398|FullyQualifiedName~ShouldUseDefaultProxyCredentials_IsExplicitOptIn_Issue3369" -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ShouldUseDefaultProxyCredentials_IsExplicitOptIn_Issue3369" -p:UseSharedCompilation=false --no-restore
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes --no-restore
  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restore
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json

Documentation and Changelog

  • Updated USER_GUIDE.md with the explicit proxy credential opt-in.
  • Added changelog.d/unreleased/3398.security.md.
  • Added changelog.d/unreleased/3369.security.md.

Review

  • Codex adversarial review: No blocking/actionable issues found.

Fixes #3398
Fixes #3369

@Widthdom
Widthdom marked this pull request as ready for review June 13, 2026 15:48
@Widthdom
Widthdom merged commit 35c85f9 into main Jun 13, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3398-3369 branch June 13, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant