Harden Docker image and narrow build context - #3615
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdidxas the/repoowner or the dedicated UID so bind-mounted repositories remain writable without keeping the CLI process as root..dockerignore, and pass release build metadata through explicit build args/MSBuild overrides instead of relying on.gitin the context.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ReleaseWorkflowTests" -p:UseSharedCompilation=falsedotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet run --project tools/CodeIndex.Changelog -- checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsondotnet build src/CodeIndex/CodeIndex.csproj -c Release -p:CdidxBuildCommitOverride=abc1234 -p:CdidxBuildDateOverride=2026-01-02 -p:CdidxBuildDirtyOverride=clean -p:UseSharedCompilation=falsedotnet src/CodeIndex/bin/Release/net8.0/cdidx.dll --version --jsonsh -n scripts/docker-entrypoint.shcodex exec review --base origin/main --ignore-user-config --ignore-rules --ephemeralreported no blocking or actionable issues.Docker smoke build was attempted with
docker build --target runtime --progress=plain -t cdidx-issue3492-3493-smoke ., but the local Docker daemon is not running (Cannot connect to the Docker daemon at unix:///Users/widom/.docker/run/docker.sock).Fixes #3492
Fixes #3493