Skip to content

Fix GitHelper cancellation test threshold - #3648

Merged
Widthdom merged 1 commit into
mainfrom
fix-issue3643
Jun 15, 2026
Merged

Fix GitHelper cancellation test threshold#3648
Widthdom merged 1 commit into
mainfrom
fix-issue3643

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Relax GitHelper cancellation wall-clock assertions from 2 seconds to a shared 4-second bound that still stays below the fake git scripts' 5-second natural completion.
  • Document the GitHelper cancellation test contract in both English and Japanese sections of TESTING_GUIDE.md.
  • Add changelog fragment changelog.d/unreleased/3643.fixed.md.

Validation

  • dotnet build CodeIndex.sln -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --filter "FullyQualifiedName~GitHelperTests" -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • Adversarial review: No blocking/actionable issues found.

Documentation and changelog

  • Updated TESTING_GUIDE.md in English and Japanese.
  • Added changelog.d/unreleased/3643.fixed.md.
  • Did not edit CHANGELOG.md.

Follow-up candidates

  • None.

Fixes #3643

@Widthdom
Widthdom marked this pull request as ready for review June 15, 2026 00:41
@Widthdom
Widthdom merged commit e54e0a7 into main Jun 15, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3643 branch June 15, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHelper cancellation test has too-tight wall-clock threshold on macOS CI

1 participant