Split extractor plugin registry responsibilities - #3649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtractorPluginRegistryinto focused partial files for discovery, diagnostics, pattern config handling, and plugin assembly loading.Validation
dotnet builddotnet format CodeIndex.sln --verify-no-changesdotnet run --project tools/CodeIndex.Changelog -- checkdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~ExtractorPluginRegistryTestsdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~ConfiguredPatternYamldotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~Run_StatusJsonIncludesExtractorPluginDiagnosticsdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonFull
dotnet testwas started but manually stopped after about 8 minutes with no completion output; targeted validation for the touched extension-boundary behavior passed.Documentation / Changelog
changelog.d/unreleased/3422.internal.md.Review
No blocking/actionable issues found.Follow-up Candidates
Fixes #3422