Skip to content

Split extractor plugin registry responsibilities - #3649

Merged
Widthdom merged 1 commit into
mainfrom
fix-issue3422
Jun 15, 2026
Merged

Split extractor plugin registry responsibilities#3649
Widthdom merged 1 commit into
mainfrom
fix-issue3422

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Split ExtractorPluginRegistry into focused partial files for discovery, diagnostics, pattern config handling, and plugin assembly loading.
  • Kept the existing registry facade and extension behavior intact.
  • Added an issue-based bilingual changelog fragment.

Validation

  • dotnet build
  • dotnet format CodeIndex.sln --verify-no-changes
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~ExtractorPluginRegistryTests
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~ConfiguredPatternYaml
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~Run_StatusJsonIncludesExtractorPluginDiagnostics
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json

Full dotnet test was started but manually stopped after about 8 minutes with no completion output; targeted validation for the touched extension-boundary behavior passed.

Documentation / Changelog

  • Added changelog.d/unreleased/3422.internal.md.
  • No user-facing documentation changes were required because this is an internal structure split with preserved behavior.

Review

  • Adversarial review result: No blocking/actionable issues found.

Follow-up Candidates

  • None.

Fixes #3422

@Widthdom
Widthdom marked this pull request as ready for review June 15, 2026 00:42
@Widthdom
Widthdom merged commit e40d1cf into main Jun 15, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3422 branch June 18, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExtractorPluginRegistry should be split by discovery, config parsing, loading, and diagnostics

1 participant