Skip to content

Fix package normalize stderr capture flake - #3652

Merged
Widthdom merged 1 commit into
mainfrom
fix-issue3631
Jun 15, 2026
Merged

Fix package normalize stderr capture flake#3652
Widthdom merged 1 commit into
mainfrom
fix-issue3631

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Add an internal writer-injection overload for PackageNormalizeCli.Run while keeping the public console-backed entry point unchanged.
  • Update release workflow package-normalize CLI tests to use dedicated stdout/stderr writers instead of global ConsoleCapture.
  • Add changelog fragment changelog.d/unreleased/3631.fixed.md.

Validation

  • dotnet build
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --files tools/CodeIndex.PackageNormalize/PackageNormalizeCli.cs tests/CodeIndex.Tests/ReleaseWorkflowTests.cs changelog.d/unreleased/3631.fixed.md --json
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ReleaseWorkflowTests.PackageNormalizeCli_DryRunDoesNotRewritePackage"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ReleaseWorkflowTests"
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes
  • dotnet test
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --commits HEAD --json
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • Codex adversarial review: No blocking/actionable issues found.

Documentation and changelog

  • Added changelog.d/unreleased/3631.fixed.md.
  • No user-facing docs were changed because this only adjusts test isolation and an internal testable CLI overload.

Fixes #3631

@Widthdom
Widthdom marked this pull request as ready for review June 15, 2026 01:27
@Widthdom
Widthdom merged commit d34a8c7 into main Jun 15, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3631 branch June 15, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky package normalize dry-run test can capture unrelated telemetry stderr

1 participant