Harden update checks, duplicate preflight, and upgrade diagnostics - #3843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR handles the requested issue set only:
upgradediagnostics: constrained explicit release tags, bounded suppressed installer output tails in JSON failures, sanitized install-directory probe diagnostics, and explicit installer checksum trust-boundary fields.Validation
dotnet build src/CodeIndex/CodeIndex.csproj --framework net8.0 -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --framework net8.0 --no-build --filter FullyQualifiedName~IssueDuplicatePreflightTests(11passed)dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --framework net8.0 --no-build --filter FullyQualifiedName~Suggestions_ExportIssueDrafts(6passed)dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --framework net8.0 --no-build --filter FullyQualifiedName~IssueDrafts(8passed)dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --framework net8.0 -p:UseSharedCompilation=false(7918passed,7skipped)dotnet run --project tools/CodeIndex.Changelog -- checkgit diff --check origin/main..HEADNotes
No third-party work-start comments were present on the requested issues when work began, so all requested issues were included. No
AGENT.md,CLAUDE.md, orAGENT_GUIDE.mdfiles were edited.Fixes #3831
Fixes #3823
Fixes #3822
Fixes #3750
Fixes #3708
Fixes #3700