Fix search origin filters, guard scope, and guarded candidate handling - #3846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--originas an alias for--match-originand support repeatable--exclude-originfilters.--guard-scope same-line/ MCPguardScopeand report guard scope in JSON evidence/checks.Issues
Fixes #3680
Fixes #3709
Fixes #3730
Fixes #3746
Validation
dotnet build CodeIndex.sln -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~RunSearch_OriginAliasAndExcludeOriginFilterExactSubstring_Issue3680|FullyQualifiedName~RunSearch_CatchRecipeFiltersCommentOnlyCatchMatches_Issue3709|FullyQualifiedName~RunSearch_GuardScopeSameLineUsesPrimaryMatchColumns_Issue3730|FullyQualifiedName~RunSearch_GuardFiltersKeepRequestedBudgetWithOriginFilters_Issue3423|FullyQualifiedName~RunSearch_ListRecipesJsonIncludesBuiltInAuditMetadata_Issue3144|FullyQualifiedName~ParseArgs_ParsesSearchGuardFlags_Issue2852|FullyQualifiedName~SearchUsageLineListsGuardFlags_Issue2852" -p:UseSharedCompilation=falsedotnet run --project tools/CodeIndex.Changelog -- checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsongit diff --check origin/main..HEADdotnet test CodeIndex.sln -p:UseSharedCompilation=falsepassed before merging latestorigin/main; the post-merge rerun was interrupted after 25+ minutes without failures but before the final summary.Review
Adversarial review: No blocking/actionable issues found.