Stabilize console restoration assertions - #4809
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestConsoleLock.Gateownership gate.changelog.d/unreleased/4800.fixed.md.Root cause
ConsoleCapture.CaptureAsyncrestored the original writers and released console ownership before the test readConsole.OutandConsole.Error. A parallel console-mutating test could therefore install a different writer between restoration and the assertions, causing a full-suite-only race.Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=falseConsoleCaptureTestsonnet8.0andnet9.0: 8/8 passed on each target frameworknet8.0passed (10,242 passed, 7 skipped);net9.0completed with one unrelated transient failure inCdidxConfigFileTests.RunValidate_PositionalJson_ReturnsStructuredError_Issue3892(9,783 passed, 404 skipped), and that exact test passed when rerun on both target frameworksdotnet run --project tools/CodeIndex.Changelog -- checkDocumentation and changelog
TESTING_GUIDE.md.changelog.d/unreleased/4800.fixed.md.Follow-up candidates
Fixes #4800