Skip to content

Stabilize installer cancellation readiness - #4811

Merged
Widthdom merged 3 commits into
mainfrom
fix-issue4801
Jul 24, 2026
Merged

Stabilize installer cancellation readiness#4811
Widthdom merged 3 commits into
mainfrom
fix-issue4801

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • wait for the installer PID file to contain a complete positive integer before cancelling the hung installer
  • use a bounded dedicated waiter so parallel load cannot expose the empty file created by shell redirection
  • document the test contract in English and Japanese and add a changelog fragment

Root cause

The previous fixed 100 ms cancellation could interrupt the shell after it opened the redirected PID file but before it wrote $$. The test then parsed an empty string as an integer.

Validation

Documentation and changelog

  • updated TESTING_GUIDE.md in English and Japanese
  • added changelog.d/unreleased/4801.fixed.md

Follow-up issues

Fixes #4801

@Widthdom
Widthdom marked this pull request as ready for review July 24, 2026 17:10
@Widthdom
Widthdom merged commit db33b58 into main Jul 24, 2026
11 checks passed
@Widthdom
Widthdom deleted the fix-issue4801 branch July 24, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installer cancellation test can parse an empty PID file under load

1 participant