Link console capture race fix to issue #4808 - #4815
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainwith Full-suite ConsoleCapture timeout test can restore a different writer under load #4808.Root cause
The timeout test originally captured and asserted the process-global console writers outside the shared ownership gate. Under full-suite parallel load, another capture could temporarily replace a writer, making the expected writer identity stale. The latest
mainnow snapshots and asserts the writers underTestConsoleLock.Gate; this PR records that the same stabilization resolves #4808 after the implementation landed concurrently through #4800.Validation
ConsoleCaptureTestson the final latest-main branch: 8/8 passed on both net8.0 and net9.0.dotnet run --project tools/CodeIndex.Changelog -- check: 49 fragments validated.git diff --check origin/main..HEAD: passed.Documentation and changelog
changelog.d/unreleased/4800-4808.fixed.md.mainalready contains synchronized English/JapaneseTESTING_GUIDE.mdguidance for snapshotting and asserting global console writers under the shared gate.CHANGELOG.mdis unchanged.Follow-up candidates
Fixes #4808