Speed up indexing for large codebases - #4824
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Large repositories amplified several small costs in hot indexing loops: materialized regex match collections, line arrays, temporary lists and predicates, repeated trimming and suffix checks, and scans that advanced once more after reaching their output budget. Together these produced substantial cumulative managed allocation and unnecessary work during symbol and reference extraction.
Impact
Indexing work is now streamed and bounded earlier, with fewer transient allocations. A representative full-repository measurement improved total elapsed time from 54,918 ms to 54,027 ms while indexing 24 additional branch files, and reduced cumulative managed allocation from 13,207,092,368 bytes to 13,058,802,272 bytes. The bounded-match wrapper is a struct-based enumerable, preserving the allocation-free below-cap path while checking capacity before the underlying
MoveNext()call.Validation
git diff --checkpassed