Fix symlink preflight consistency - #4922
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--follow-symlinks alldry-run and execution share resolved external file-target handling.warnings_total/warnings.Root cause
Dry-run path filtering compared resolved paths against the project root even for
all, while C# preflight and content loading could snapshot different path identities. The first correction also exposed a smaller open-time window where a followed link could be retargeted after resolution but before the stream was opened. CI then caught that handle-bound metadata alone no longer retried when the lexical path was atomically replaced after opening; post-read path identity validation now preserves that retry and reauthorization contract.Validation
remainingselection: 9,926 passed / 4 skipped / 0 faileddotnet format CodeIndex.sln --verify-no-changes --no-restoregit diff --check origin/main...HEADcdidx status --check --json(index_matches_workspace: true)Documentation and changelog
DEVELOPER_GUIDE.md.changelog.d/unreleased/4829.fixed.md.Follow-up candidates
Fixes #4829