Restore C# partial-family unused detection - #4927
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--by-bucket, and--actionableoutput.Root cause
Nested type matching omitted qualified ancestor paths, while the fallback could also flatten distinct generic containing types and count identifier occurrences outside the matched peer declaration.
Validation
net8.0andnet9.0RunUnusedsuite: 41 passed on bothnet8.0andnet9.0net8.0: 10,514 passed, 7 skipped, 0 failednet9.0: 10,041 passed, 419 skipped, 0 failedmake lintdotnet run --project tools/CodeIndex.Changelog -- checkgit diff --checkindex_matches_workspace: trueDocumentation and changelog
USER_GUIDE.mdandTESTING_GUIDE.mdin English and Japanese.changelog.d/unreleased/4834.fixed.md, referencing the Fix unused analysis for partial-class handlers and field-like symbols #3673 regression.Follow-up candidates
Fixes #4834