Fix C# constructor navigation identity filtering - #4951
Merged
Conversation
# Conflicts: # USER_GUIDE.md # src/CodeIndex/Database/DbContext.SchemaMetadata.cs # tests/CodeIndex.Tests/IndexCommandRunnerUpdateTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instantiatereferences by exact source site, generic type arity, and invocation arity.Root cause
Constructor references and type declarations shared a name-based candidate path. In partial types this allowed a same-file type declaration or an unrelated constructor shape to outrank the callable target, while LSP position resolution could then collapse the mixed candidate set to the wrong location.
Validation
dotnet build CodeIndex.sln -c Release --no-restore— passed with 0 warnings and 0 errors.net8.0andnet9.0— 15/15 passed on each framework.net9.0— 10,175 passed, 419 skipped, 0 failed.net8.0— 10,647 passed, 7 skipped, with one unrelated MCP timeout fixture failure under parallel load; the exact failed test passed 1/1 when rerun alone.dotnet format CodeIndex.sln --no-restore --verify-no-changes— passed.dotnet run --project tools/CodeIndex.Changelog -- check— validated 26 fragments.status --check --json—index_matches_workspace: true, no failed checks.Documentation and changelog
USER_GUIDE.md.TESTING_GUIDE.md.changelog.d/unreleased/4850.fixed.md.Follow-ups
None.
Fixes #4850