Keep query and status indexed HEAD stamps consistent - #4952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata.indexed_at_head_shause the latest successfulindexed_head_sha, with legacy full-scan fallback only when the latest key is absent.Root cause
Query envelopes read the full-scan-only
indexed_head_commitinstead of the latest successfulindexed_head_sha. A simple value fallback could not distinguish an absent legacy key from a present NULL value, and envelope construction could reread HEAD metadata after the response rows or generation validation had completed.Validation
dotnet restore CodeIndex.slndotnet build CodeIndex.sln -c Release --no-restore --nologo— 0 warnings, 0 errorsdotnet test CodeIndex.sln -c Release --no-build --no-restore— net8.0: 10,637 passed / 7 skipped / 0 failed; net9.0: 10,164 passed / 419 skipped / 0 failedJsonEnvelopeWrapperTests— 21/21 passed on both net8.0 and net9.0dotnet format CodeIndex.sln --verify-no-changes --no-restore --include src/CodeIndex/Cli/JsonEnvelopeWrapper.cs tests/CodeIndex.Tests/JsonEnvelopeWrapperTests.csdotnet run --project tools/CodeIndex.Changelog -- check— 26 fragments validcdidx index . --commits HEAD --jsonandcdidx status --check --json— clean,index_matches_workspace: true, no failed checksAdversarial review
Changelog
changelog.d/unreleased/4854.fixed.mdFollow-up
backfill-foldNULL folded-value issue; it is not fixed by this PR.Fixes #4854