Emit one stable error for invalid outline projections - #4971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--outline-fieldsvalues and emit one terminal usage error with the invalid names and valid candidatesall/specific-field validation after that terminal projection errorRoot cause
ParseOutlineProjectionFieldsappended an unsupported-field error while parsing and then continued into downstream empty-selection validation. Invalid-only input therefore produced two top-level diagnostics. The parser now records invalid fields and returns immediately after emitting the single consolidated projection error.Validation
dotnet build CodeIndex.sln -p:UseSharedCompilation=false— passed, 0 warnings / 0 errorsdotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false— passed, 0 warnings / 0 errorsRunOutlinetests — 48 passeddotnet format CodeIndex.sln --verify-no-changes --no-restore— passeddotnet run --project tools/CodeIndex.Changelog -- check— 46 fragments validatedindex . --commits HEADfollowed bystatus --check --json—index_matches_workspace: trueFull-suite note:
RunCore_SubprojectObservesAncestorIgnoreFileChanges_Issue4592; its isolated retry passedNo changes for #4592 are included because this PR is scoped to #4876.
Documentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.mdchangelog.d/unreleased/4876.fixed.mdCHANGELOG.mdAdversarial review
Codex reviewed
origin/main..HEAD: No blocking/actionable issues found.Fixes #4876