Reuse bounded sessions for parallel batch queries - #4972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdidx batch --parallelworker slot instead of reopening and reproving the database for every item.changelog.d/unreleased/4872.fixed.md.Root cause and performance evidence
Profiling used a dedicated approximately 717 MB CodeIndex database and the locally built Debug
cdidx.dll.--parallel 4A heavier mixed workload also remained faster in parallel (144.84 s serial versus 130.84 s parallel). The deterministic regression guard uses warmup and a generous ratio (
12-item / 3-item <= 3.0) rather than an absolute duration.Validation
dotnet build tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-restore -p:UseSharedCompilation=false— passed with 0 warnings and 0 errors after syncing currentorigin/main.RunBatch_*contract tests — 41/41 passed on both net8.0 and net9.0 after review fixes.Issue4557) — 13/13 passed on both net8.0 and net9.0.dotnet run --project tools/CodeIndex.Changelog -- check— validated 48 fragments after main sync.dotnet format CodeIndex.sln --no-restore --verify-no-changes— passed.git diff --check origin/main..HEAD— passed.Adversarial review
Two mandatory
codex review --base origin/mainrounds were completed (the workflow maximum). The first round identified detached-snapshot staleness and reader-construction cleanup; the second identified checkpointed/direct-session freshness proof and initial-validation cleanup. All findings were addressed with signal-driven regressions for hot/checkpointed WAL, direct journal mode, and failure cleanup.Documentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.md.changelog.d/unreleased/4872.fixed.md.Follow-up candidates
None.
Fixes #4872