Preserve audit alias command identity - #4974
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auditinvocation context while delegating to the shared search and recipe pipeline.cdidx auditwithout leaking internalsearch --recipesyntax.searchbehavior unchanged, centralize structured audit errors, honor--max-json-bytes, and use audit syntax in generated replay and cursor guidance.Root cause
The audit alias forwarded into the search implementation without carrying the originally invoked public command. Downstream validation, error serialization, recovery hints, and generated commands therefore reconstructed messages from the internal
search --recipepath.Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false— 0 warnings, 0 errors after merging the latestorigin/main.net8.0andnet9.0— 2/2 passed on each target after the merge.net8.0andnet9.0— 262/262 passed on each target.net8.0suite — 10,809 passed, 7 skipped, 0 failed.net9.0suite — 10,334 passed, 420 skipped; one unrelated watcher timing test failed during the concurrent run and passed immediately in isolatednet9.0retry (and onnet8.0andorigin/main).dotnet format CodeIndex.sln --verify-no-changes --no-restore.codex review --base origin/main— two adversarial-review iterations completed; all four actionable findings were fixed and their exact reproductions are covered.Follow-up candidates
None.
Fixes #4875