Add JSON byte budgeting to outline - #4980
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outline --max-json-bytesusing the shared whole-row bounded JSON envelope.response:v2cursor pages, with authoritative totals and complete UTF-8 JSON rows.Root cause
outlinehad its own pagination and output shape but was not registered for the shared bounded-response path. Supporting it also required outline-specific row extraction and validation handling so byte capping could not silently change existing option semantics.Validation
dotnet build --no-restore(0 warnings, 0 errors)net8.0andnet9.0(4/4 each)Outline|JsonEnvelopeWrapper|CliFlagSchematests onnet8.0andnet9.0(160/160; 158 passed, 2 skipped)make lintgit diff --checkThe combined full-suite run reported 4 failures on
net8.0and 3 onnet9.0. The Issue #4872 and Issue #4602 cases passed when rerun. The remaining watcher instability is already tracked by #4955 and #4966.Documentation and changelog
README.md,USER_GUIDE.md,DEVELOPER_GUIDE.md, andTESTING_GUIDE.md.changelog.d/unreleased/4880.added.md.Fixes #4880