Stabilize ancestor ignore watcher coverage on macOS - #4987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignoreon macOS.FileSystemWatcherdelivery coverage on Linux and Windows while retaining the bounded database reconciliation assertion on every platform.TESTING_GUIDE.md.changelog.d/unreleased/4966.internal.md.Root cause and scope
On macOS,
FileSystemWatcher/FSEvents delivery for a newly written ancestor.gitignorecan be silently delayed or dropped. The reported net9.0 test timed out, and an isolated net8.0 run reproduced the same timeout when real delivery was preserved. Injecting the exact production enqueue callback showed that classification, debounce, and full reconciliation complete within the existing bound.This PR changes test orchestration only; production watcher behavior is unchanged. The deterministic handoff is limited to macOS, where runtime delivery is not a stable test oracle.
Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -f net9.0 --no-restore --no-build -p:UseSharedCompilation=false --filter FullyQualifiedName=CodeIndex.Tests.IndexWatchRunnerTests.RunCore_SubprojectObservesAncestorIgnoreFileChanges_Issue4592dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -f net8.0 --no-restore --no-build -p:UseSharedCompilation=false --filter FullyQualifiedName=CodeIndex.Tests.IndexWatchRunnerTests.RunCore_SubprojectObservesAncestorIgnoreFileChanges_Issue4592dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -f net9.0 --no-restore --no-build -p:UseSharedCompilation=false --filter FullyQualifiedName~CodeIndex.Tests.IndexWatchRunnerTests(51 passed)dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=falsedotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet run --project tools/CodeIndex.Changelog -- checkNo blocking/actionable issues found.Follow-up candidates
None.
Fixes #4966