Make workspace status CI-actionable - #4988
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project_exists/db_existsfields while retainingexistsas a compatibility aliasworkspace status --checkwith stable aggregate exits: healthy0, missing2, degraded5, malformed input1Root cause
Workspace status exposed member
existsfor project-directory existence besideindex_health.db_exists, and its informational success exit was the only behavior even when required member indexes were absent. Consumers therefore had neither an unambiguous existence contract nor a CI enforcement mode.Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false(0 warnings, 0 errors)dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -f net8.0 --no-build --no-restore -p:UseSharedCompilation=false(10,868 passed, 7 skipped, 0 failed)dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -f net9.0 --no-build --no-restore -p:UseSharedCompilation=false(10,394 passed, 420 skipped, 0 failed)WorkspaceCommandRunnerTests(70 passed)dotnet format CodeIndex.sln --no-restore --verify-no-changesdotnet run --project tools/CodeIndex.Changelog -- check--check, JSON, and helpDocumentation and changelog
Updated the English and Japanese README, developer guide, testing guide, and
changelog.d/unreleased/4885.changed.md.Fixes #4885