Stabilize macOS net8 subproject watch reconciliation - #4989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileSystemWatcher/FSEvents while polling only the exact ancestor.gitignoreand.cdidxignorepaths.Root cause
On macOS under .NET 8, the FSEvents path can silently miss changes to ancestor ignore files when watching a subproject. Extending the reconciliation wait to 60 seconds did not recover, confirming an event-delivery miss rather than slow synchronization. The fix supplements normal project-tree events with a bounded exact-path poll of ancestor ignore files, avoiding recursive idle scans of the subproject.
Validation
Documentation / changelog
USER_GUIDE.mdDEVELOPER_GUIDE.mdTESTING_GUIDE.mdchangelog.d/unreleased/4955.fixed.mdFollow-up candidates
None.
Fixes #4955