Skip checkpoints for completed no-op backfills - #4991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--checkpoint, preserve--no-checkpoint, and report stablecheckpoint_skipped/checkpoint_skipped_reasonoutput in JSON and human-readable modes.Root cause
backfill-foldcreated its automatic checkpoint before it determined whether any row or readiness mutation was required. Moving only the pending-row count was insufficient because non-NULL folded values can still be stale, so the preflight also validates persisted values before returningalready_complete.Validation
dotnet restore CodeIndex.slndotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet test CodeIndex.sln -c Release --no-build -p:UseSharedCompilation=falsedotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet run --project tools/CodeIndex.Changelog -- checkstatus --check --json: fresh and matchedDocumentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.md.changelog.d/unreleased/4889.fixed.md.AGENTS.md,CLAUDE.md,AGENT_GUIDE.md, orCHANGELOG.md.Follow-up candidates
Fixes #4889