Explain every serialized status section - #4995
Merged
Merged
Conversation
# Conflicts: # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status --explainkeys from the source-generatedStatusResultserializer registry--fields, and keep bounded explain envelopes free of runtime/path metadatamainRoot cause
The explain command used a hand-maintained allowlist that could drift from the serialized status response, and the generic bounded-response wrapper added runtime metadata to otherwise static explanations.
Validation
dotnet build CodeIndex.sln -c Release --no-restore— 0 warnings, 0 errorsdotnet format CodeIndex.sln --verify-no-changes --no-restoreAn additional review-only Debug full-suite run encountered a test-generated unreadable fixture in
LocalJsonlJsonWriterOptionsTests; the canonical Release suites above were green, and the affected focused tests passed after the final correction.Documentation and changelog
Updated the bilingual README, Developer Guide, Testing Guide, and
AGENT_GUIDE.md. Addedchangelog.d/unreleased/4891.fixed.md.Follow-up candidates
None.
Fixes #4891