Add bounded MCP language catalog pagination - #5000
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxBytesagainst the complete UTF-8 JSON-RPC response envelope and report whether byte budget or item limit caused continuation.Validation
dotnet restore CodeIndex.slndotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false— succeeded with 0 warnings and 0 errors on the final merged HEAD.Issue4895,Issue4896,McpToolContractTests,RunLanguages, andToolsCall_Languages) — 70 passed on net8.0 and 70 passed on net9.0.origin/main— net8.0: 10,962 passed / 7 skipped / 0 failed on the clean rerun; net9.0: 10,487 passed / 420 skipped / 0 failed. The final merge overlap is covered by the final 70-test suite above.dotnet format CodeIndex.sln --verify-no-changes --no-restore --verbosity minimaldotnet run --project tools/CodeIndex.Changelog -- check— 72 fragments validated.git diff origin/main..HEAD --checkstatus --check --json— index matches the final workspace with 0 warnings and 0 errors.Adversarial review
Documentation and changelog
USER_GUIDE.md,DEVELOPER_GUIDE.md, andTESTING_GUIDE.mdin their English and Japanese sections.changelog.d/unreleased/4896.added.md.Fixes #4896
Follow-ups