Require safe paths for summarize_file MCP prompt - #5006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summarize_fileprompt'spathargument as required in prompt discovery.-32602errors for missing, null, non-string, blank, absolute, drive-prefixed, control-character-containing, or traversing paths instead of rendering an unresolved<path>placeholder.changelog.d/unreleased/4899.fixed.md.Root cause and impact
The prompt metadata described
pathas optional andprompts/getrendered a placeholder when it was absent. Path input also lacked prompt-specific validation. Clients could therefore receive a non-actionable template, and unsafe or platform-misclassified path text could be interpolated into the prompt. The prompt now fails early with typed errors and only renders a validated concrete indexed path.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -f net8.0 -p:UseSharedCompilation=false --no-restore --filter 'FullyQualifiedName~Prompts'— 18 passeddotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -f net9.0 -p:UseSharedCompilation=false --no-restore --filter 'FullyQualifiedName~Prompts'— 18 passeddotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restore— 0 warnings, 0 errorsdotnet build src/CodeIndex/CodeIndex.csproj -c Debug -f net8.0 -p:UseSharedCompilation=false --no-restore— 0 warnings, 0 errorsdotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet run --project tools/CodeIndex.Changelog -- check— 74 fragments validated-32602; POSIXsrc\..\file.cspreservedbackfill-foldAdversarial review
Two mandatory Codex adversarial-review rounds were completed. The review findings covered POSIX backslash preservation, control-character rejection, and platform-aware traversal validation; all reported findings were addressed with regression coverage.
Follow-up
Fixes #4899