Skip to content

Make safety audits operation- and polarity-aware - #5018

Merged
Widthdom merged 5 commits into
mainfrom
fix-issue4911
Aug 1, 2026
Merged

Make safety audits operation- and polarity-aware#5018
Widthdom merged 5 commits into
mainfrom
fix-issue4911

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • classify static Regex audit matches by member semantics and suppress only proven BCL Regex.Escape/Regex.Unescape
  • classify UseShellExecute assignments by polarity and suppress only direct literal false
  • retain unsafe and unresolved findings across aliases, source-defined receivers, legacy identity data, comments/strings, multiline/computed values, and saturated candidate sets

Validation

  • Release build for net8.0/net9.0: 0 warnings, 0 errors
  • full net8.0 suite: 11,062 passed, 7 skipped, 0 failed
  • full net9.0 suite: 10,587 passed, 420 skipped; existing Avoid overhead that makes parallel batch slower than sequential #4872 timed out once under full-suite load and passed on isolated rerun
  • focused and related audit tests passed on net8.0/net9.0
  • dotnet format CodeIndex.sln --verify-no-changes --no-restore
  • changelog fragment validation (88 fragments)
  • fresh HEAD index and dogfood shell/bare-Regex/qualified-Regex audits (0 findings)
  • Codex adversarial review rounds 1 and 2; all actionable findings fixed

Documentation and changelog

  • updated the English and Japanese sections of USER_GUIDE.md and TESTING_GUIDE.md
  • added changelog.d/unreleased/4911.fixed.md

Fixes #4911

@Widthdom
Widthdom marked this pull request as ready for review August 1, 2026 02:50
@Widthdom
Widthdom merged commit 6e64c70 into main Aug 1, 2026
12 checks passed
@Widthdom
Widthdom deleted the fix-issue4911 branch August 1, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make safety audits understand safe helper and negative-policy semantics

1 participant