Use structural evidence for safety audit guards - #5021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnumerationOptionsvalue actually passed toDirectory.Enumerate*, including named arguments, lexical scope, and shadowingValidation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Debug -f net8.0 --no-restore --filter FullyQualifiedName~Issue4912(3 passed)dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Debug -f net9.0 --no-restore --filter FullyQualifiedName~Issue4912(3 passed)dotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet run --project tools/CodeIndex.Changelog -- check(86 fragments validated)dotnet build CodeIndex.sln -c Debug --no-restore(0 warnings, 0 errors)dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll audit risky-code/file-read-all-text --allow-partial --format compact(0 findings)dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll audit phrase-risk-patterns/readalltext-call-site --allow-partial --format compact(0 findings)dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll audit filesystem-traversal/enumerate-without-options --allow-partial --format compact(4 remaining reviewable findings; 3 structurally safe calls excluded)index . --commits HEAD --json(1,324 files, 11,070 chunks, 46,618 symbols, 458,577 references; 0 warnings/errors; index and reference graph complete/current)codex review --base origin/mainadversarial-review rounds completed; all 15 actionable findings were fixed and regression-testedDocumentation and changelog
USER_GUIDE.mdandTESTING_GUIDE.mdchangelog.d/unreleased/4912.fixed.mdFollow-ups
Fixes #4912