Fix stable C# generic outline signatures - #5025
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The outline display builder treated callable parsing as an ordinary parameter-list lookup. Generic declarations could not reliably identify the method type-parameter list or lexically split complex C# parameters, so they fell back to line-based names such as
Name@line.Impact
Generic overloads now receive distinct, line-stable display names such as
Convert<T>(T)andConvert<T1, T2>(T1, ref T2). Canonical paths, stored symbol identity, and exact-query aliases are unchanged. Incomplete legacy signatures retain the existingName@linefallback.Fixes #4916
Documentation and changelog
README.md,DEVELOPER_GUIDE.md, andTESTING_GUIDE.mdchangelog.d/unreleased/4916.fixed.mdCHANGELOG.mdValidation
DbReaderTestsafter the final review fixes: net8.0 682 passed; net9.0 681 passed, 1 skippeddotnet build CodeIndex.sln -c Release --no-restore: 0 warnings, 0 errorsdotnet format CodeIndex.sln --no-restore --verify-no-changesdotnet run --project tools/CodeIndex.Changelog -- checkgit diff --checkstatus --check --json: fresh, complete graph/reference/fold state, no failed checksAdversarial review
Two Codex adversarial-review rounds were completed, the workflow maximum. Round-one findings covering placeholder collisions, lexical Unicode normalization, delimiter splitting, and Unicode identifiers were addressed. Round-two findings covering nested interpolated defaults, attribute comparison expressions, and comment trivia around generic delimiters were also addressed and regression-tested.
Follow-up candidates
None identified within the scope of Issue #4916.