Skip to content

Remove superseded internal helpers - #5028

Merged
Widthdom merged 1 commit into
mainfrom
fix-issue4917
Aug 1, 2026
Merged

Remove superseded internal helpers#5028
Widthdom merged 1 commit into
mainfrom
fix-issue4917

Conversation

@Widthdom

@Widthdom Widthdom commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove StringRowsEqual, whose callers were superseded by the ordered diff path that already determines equality.
  • Remove QuotedIncludeRegex, because the active shader IncludeRegex handles both quoted and angle-bracket includes.
  • Remove HasPrologClauseTerminator and PreferDefinitionAtPosition, whose call paths now use the top-level Prolog terminator scanner and direct position-aware definition resolution.
  • Add the required bilingual internal changelog fragment.

Validation

  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false (0 warnings, 0 errors)
  • dotnet format CodeIndex.sln --verify-no-changes --no-restore
  • Focused behavior tests: 8/8 passed on both net8.0 and net9.0
  • Full net8.0 suite: 11,085 passed, 7 skipped, 0 failed
  • Full net9.0 suite: 10,611 passed, 420 skipped, 0 failed
  • Changelog validator: 93 fragments validated
  • Local index freshness: 1,333/1,333 files matched; all four removed names return 0 exact matches
  • Codex adversarial review: no blocking or actionable findings

Documentation / changelog

  • Added changelog.d/unreleased/4917.internal.md in English and Japanese.
  • No public documentation change is needed because this removes unreachable private helpers without changing behavior.

Follow-up candidates

  • None.

Fixes #4917

@Widthdom
Widthdom merged commit 3cecebb into main Aug 1, 2026
11 checks passed
@Widthdom
Widthdom deleted the fix-issue4917 branch August 1, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve four confirmed unused internal helpers

1 participant