Preserve JSON envelope option values - #5029
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--json-envelopeas separated, inline, and positional query data across normal and bounded preprocessingRoot cause and impact
Raw token equality removed
--json-envelopeeven when it was command data, shifting later arguments. Bounded preprocessing had the same behavior. A schema-only first pass also over-consumed the flag after missing option values; token classification now matches parser acceptance.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-restore -p:UseSharedCompilation=false --filter FullyQualifiedName~JsonEnvelopeWrapperTests(25/25 on net8.0 and 25/25 on net9.0)dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false(0 warnings, 0 errors)dotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet run --project tools/CodeIndex.Changelog -- check(101 valid fragments)git diff --checkcdidx indexupdate and strict workspace/fold/graph status checksFixes #4976
Follow-up candidates: None.