Repair mixed folded backfill state - #5030
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The preflight selected a targeted NULL-only backfill whenever missing values were present, so non-NULL stale rows survived and final verification failed. Interrupted promoted rewrites could also leave a full-rewrite checkpoint that a targeted retry ignored, including an end-of-table checkpoint that the CLI previously treated as a no-op.
Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restore(0 warnings, 0 errors)dotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet run --project tools/CodeIndex.Changelog -- checkA broader solution test run encountered one unrelated timing-sensitive MCP concurrency failure under shared-host load; the exact test passed independently on both .NET 8 and .NET 9.
Documentation and changelog
TESTING_GUIDE.mdin English and Japanese.changelog.d/unreleased/4946.fixed.md.Follow-up candidates
Fixes #4946