Isolate Git-based tests from user configuration - #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES #217
Summary
TestGitRepositoryinitialization path for every temporary Git repository used by the test suiteRoot cause and impact
The existing tests initialized repositories directly and therefore inherited settings such as
commit.gpgSign=true. Signed commits could prompt, fail, or hang on developer machines. Other inherited inputs such asGIT_CONFIGand per-user ignore files could also make otherwise deterministic test setup fail.Validation
dotnet build FolderDiffIL4DotNet.sln --configuration Release --no-restore --nologo -m:1dotnet test FolderDiffIL4DotNet.Tests/FolderDiffIL4DotNet.Tests.csproj --configuration Release --no-restore --nologo -m:1— 2035 passed, 1 existing E2E opt-in skipGIT_CONFIG=/dev/null— 4 passeddotnet format --verify-no-changespython3 scripts/validate-test-scope-map.py— 93/93 test classes documentedgit diff --checkorigin/main..HEAD— no remaining findingsThe repository-wide format check still reports pre-existing whitespace findings in unrelated files; all C# files changed by this PR pass the scoped format check.