Polish focus, fonts, and tooltip alignment - #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Yu Gothic UIorMeiryofor unsupported characters.Root cause
The Create button used a zero-width border and did not suppress the default focus adorner, so its focused appearance diverged from the top-bar text fields. Windows also overrode the intended Inter stack with an installed Segoe family even though Inter was not bundled. Finally, the caption tooltip style had more bottom margin than top margin, which shifted its text above the visual center.
The first font implementation applied the embedded Inter family to every platform. Because Inter does not contain Japanese glyphs, this caused missing-glyph boxes on macOS. The follow-up scopes the embedded family to the existing
.windowsclass and uses Avalonia's composite font family support for Windows Japanese fallbacks.User impact
Keyboard focus is visually consistent across the top bar, Windows typography no longer depends on the installed Latin UI font, Japanese text remains supported on Windows, macOS/Linux retain their prior typography, and compact button tooltips read as vertically centered.
Validation
dotnet build Praxis.Avalonia/Praxis.Avalonia.csproj -c Release --nologodotnet test Praxis.Tests/Praxis.Tests.csproj -c Release --nologo— 614 passeddotnet build Praxis.slnx -c Debug --nologogit diff --checkcdidx status --check --json— fresh, no failed readiness checksScreenshots
The reported macOS missing-glyph screenshot was used to identify the regression. A corrected capture could not be created in the automation session because macOS Screen Recording permission was unavailable. A Windows capture is still recommended to verify ClearType rendering and final optical alignment on the target platform.