feat(widget): auto-detect locale from browser, ship FR/ES/DE presets - #77
Merged
Merged
Conversation
The widget had a `WidgetLocale` type but only an English `DEFAULT_LOCALE`, so hosts had to ship their own translations to get a non-English UI. Add built-in `LOCALES` (en/fr/es/de) and a `language` config field, and have the context auto-detect from `<html lang>` or `navigator.language` when the host doesn't pass one. Hosts can still override individual strings via `config.locale` on top of the resolved preset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The widget had a
WidgetLocaletype but only an EnglishDEFAULT_LOCALE, so hosts had to ship their own translations to get a non-English UI (e.g. the French page in the screenshot rendered an English widget).packages/shared/src/locales.tsshipsLOCALESwith English, French, Spanish, and German translations of the fullWidgetLocale, plusresolveLocale(language)anddetectBrowserLanguage()helpers.WidgetConfiggains an optionallanguagefield.KoeContextnow resolves the base locale viaconfig.language ?? <html lang> ?? navigator.language, falling back to English.config.localeis still merged on top so hosts can pick a language and override individual keys.@wifsimster/koe.Usage
Auto-detected from the host page:
Or explicit:
Test plan
pnpm turbo run build(all 4 packages)pnpm typecheck(all 4 packages)pnpm test(89 API tests pass)<html lang="fr">page and confirm French strings renderGenerated by Claude Code