Fixing PAL and NTSC-U region issues and updated Touch! Generations#16
Fixing PAL and NTSC-U region issues and updated Touch! Generations#16Barcia04 wants to merge 10 commits intoWiiLink24:mainfrom
Conversation
…ect region Added country exclusive title ID code in order to fix DSiWare, and DSi games not appearing, and Wii, WiiWare, 3DS, and DS suffering the same in PAL regions. Added Special NTSC-U region, these regions are either Special Editiosn such as Walmart or Toys R' Us which they are blacklisted or Canadian releases. Some games (a small amount of them) are labeled wrong in GameTDB, these games are labeled as PAL instead of NTSC-U, so I added a code to force them to change to NTSC-U
Updated Touch Generations! IDs to include all region exclusive titles. Added variable to force titleIDs wrongly labeled to their correct region.
noahpistilli
left a comment
There was a problem hiding this comment.
Please test your changes before making a pull request. As of right now these changes break everything.
| "YBN", "VAAE", "VAAV", "AYA", "AND", "ANM", "ATD", "ADJ", "BET", "CNVP", "CNVF", "CNVD", "CNVI", "CNVS", "ANH", "ANG", "AUA", "AUB", "AUC", "AUD", "AUE", "AIX", "AIZ", | ||
| "YCU", "ATI", "AOS", "AG3", "AWIE", "APLE", "AJQE", "AJQJ","CM7", "BKCE", "ATG", "AVM", "AD5", "AD2", "ADG", "AD7", "AD3", "IMW", "IA8", "C6P", "AXP", "A4VJ", "AJM", "AOI" | ||
| "A8NE", "A2Y", "AZI", "ASQ", "AJY", "ATR", "ARJ", "AGFE", "USK", "VET", "YFCE" "YLZP", "YLZX", "YLZJ", "YNU", "SUPP", "SUPJ", "RFN", "RFP", "R64", "RYW", "RHAP", "RHAJ", | ||
| "RJT", "RSPP", "RSPJ", "RZTP", "RFBP", "R4EP", "RNOP", "RTYP", "SP2P", |
There was a problem hiding this comment.
Where did you source these IDs from?
There was a problem hiding this comment.
All these were sourced from different sources:
- Wikipedia which in itself is a bad source and was only used for reference since it had a huge list compared to other sites.
- By having some of these games which in the cover they do have the Touch! Generations logo.
- Nintendo Japan website for Wii and DS which suprisingly is still up.
- GameFAQs alongside GameTDB and Wikipedia by checking covers and if the list is correct.
- Old Touch! Generations page through Wayback Machine.
- Nintendo Europe page.
| var regionToCodeTDB = map[constants.Region][]byte{ | ||
| constants.NTSC: {'E', 'L', 'X', 'Z'}, | ||
| constants.PAL: {'P', 'F', 'D', 'S', 'I', 'H', 'U', 'X', 'Y', 'V', 'Z'}, | ||
| constants.Japan: {'J'}, |
There was a problem hiding this comment.
You changed the value of the map from byte to an array of byte, therefore you must alter all code that references this map to reflect the change.
There was a problem hiding this comment.
By accident I forgot to change the references. Apparently this now is fixed!
If not I found another way to implement this and avoid wrong games, by deleting this line and references and hardcoding chinese and iQue titles to be blacklisted and changing game regions that are wrongly labeled
| forcedRegion := game.Region | ||
| isForced := slices.Contains(constants.CanadaUSAIDs, game.ID[:4]) | ||
|
|
||
| if isForced { | ||
| forcedRegion = "NTSC-U" | ||
| } |
There was a problem hiding this comment.
This does literally nothing. forcedRegion is never used anywhere. Furthermore, since you only assign and never access forcedRegion, this won't even compile.
There was a problem hiding this comment.
Sorry! Forgot to implement it correctly. Please tell me if the changes are correct!
Attempted to fix region code that was badly implemented alongside the CanadaUSA IDs getting the ForceRegion implemented but not getting used.
Added missing commas in the Touch! Generation IDs causing syntax errors.
Added additional IDs to the CanadaUSAIDs list.
…ng in Touch! Generationsr: Cooking Removed duplicate entries and cleaned up the TouchGenIDs list, due to being in the Gen in all regions not Europe only.
Updated PAL region codes an added 'W' title ID, this type of code is used the same way as 'X, Y, Z" by cartdridge, disc or channel limitations, or publishing.
Barcia04
left a comment
There was a problem hiding this comment.
Fixed the issues and updated the code. Everything should be good now. Please let me know if I forgot something!
| var regionToCodeTDB = map[constants.Region][]byte{ | ||
| constants.NTSC: {'E', 'L', 'X', 'Z'}, | ||
| constants.PAL: {'P', 'F', 'D', 'S', 'I', 'H', 'U', 'X', 'Y', 'V', 'Z'}, | ||
| constants.Japan: {'J'}, |
There was a problem hiding this comment.
By accident I forgot to change the references. Apparently this now is fixed!
If not I found another way to implement this and avoid wrong games, by deleting this line and references and hardcoding chinese and iQue titles to be blacklisted and changing game regions that are wrongly labeled
| forcedRegion := game.Region | ||
| isForced := slices.Contains(constants.CanadaUSAIDs, game.ID[:4]) | ||
|
|
||
| if isForced { | ||
| forcedRegion = "NTSC-U" | ||
| } |
There was a problem hiding this comment.
Sorry! Forgot to implement it correctly. Please tell me if the changes are correct!
Title ID "AOS" has been updated to "AOSE" due to not being considered a Touch! Generations title on Europe and Japan, only on America.
INFO: