chore: willboosterify this repo#150
Merged
WillBooster-bot merged 1 commit intomainfrom May 9, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, including @willbooster/wb, build-ts, and Babel-related packages. A review comment identifies a version mismatch for @typescript/native-preview, noting that it was downgraded in package.json while the updated build-ts requires a newer version, resulting in redundant package versions.
| "@tsconfig/node24": "24.0.4", | ||
| "@types/node": "24.12.2", | ||
| "@typescript/native-preview": "7.0.0-dev.20260503.1", | ||
| "@typescript/native-preview": "7.0.0-dev.20260421.2", |
There was a problem hiding this comment.
This change downgrades @typescript/native-preview, while the updated build-ts dependency requires a newer version (7.0.0-dev.20260503.1). This results in two versions of the same package in your project.
To maintain consistency and avoid redundancy, it's recommended to use the newer version required by build-ts.
Suggested change
| "@typescript/native-preview": "7.0.0-dev.20260421.2", | |
| "@typescript/native-preview": "7.0.0-dev.20260503.1", |
References
- Rule 6: Simplify code as much as possible to eliminate redundancy. Having two versions of the same dependency is a form of redundancy that should be eliminated to simplify the project. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.