Skip to content

chore: willboosterify this repo#21

Merged
WillBooster-bot merged 1 commit intomainfrom
wbfy
May 8, 2026
Merged

chore: willboosterify this repo#21
WillBooster-bot merged 1 commit intomainfrom
wbfy

Conversation

@WillBooster-bot
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @willbooster/wb dependency to version 13.12.14 and adds @types/* to the list of preapproved npm packages in .yarnrc.yml. In oxlint.config.ts, the import was refactored to use an intermediate variable, which the reviewer flagged as redundant. Following the repository's style guide, it is recommended to simplify the import to eliminate unnecessary assignments.

Comment thread oxlint.config.ts
Comment on lines +2 to +4
import oxlintBaseConfig from '@willbooster/oxlint-config';

const oxlintResolvedConfig = oxlintBaseConfig;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current implementation introduces redundancy by importing the configuration as oxlintBaseConfig and then immediately assigning it to oxlintResolvedConfig without any modifications. According to the repository style guide (Rule 6), code should be simplified as much as possible to eliminate redundancy. Unless there is an immediate plan to add custom configurations between these lines, it is better to import the configuration directly as oxlintResolvedConfig.

Suggested change
import oxlintBaseConfig from '@willbooster/oxlint-config';
const oxlintResolvedConfig = oxlintBaseConfig;
import oxlintResolvedConfig from '@willbooster/oxlint-config';
References
  1. Simplify code as much as possible to eliminate redundancy. (link)

@WillBooster-bot WillBooster-bot merged commit 5e1c721 into main May 8, 2026
10 checks passed
@WillBooster-bot WillBooster-bot deleted the wbfy branch May 8, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant