chore: willboosterify this repo#21
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the @willbooster/wb dependency to version 13.12.14 and adds @types/* to the list of preapproved npm packages in .yarnrc.yml. In oxlint.config.ts, the import was refactored to use an intermediate variable, which the reviewer flagged as redundant. Following the repository's style guide, it is recommended to simplify the import to eliminate unnecessary assignments.
| import oxlintBaseConfig from '@willbooster/oxlint-config'; | ||
|
|
||
| const oxlintResolvedConfig = oxlintBaseConfig; |
There was a problem hiding this comment.
The current implementation introduces redundancy by importing the configuration as oxlintBaseConfig and then immediately assigning it to oxlintResolvedConfig without any modifications. According to the repository style guide (Rule 6), code should be simplified as much as possible to eliminate redundancy. Unless there is an immediate plan to add custom configurations between these lines, it is better to import the configuration directly as oxlintResolvedConfig.
| import oxlintBaseConfig from '@willbooster/oxlint-config'; | |
| const oxlintResolvedConfig = oxlintBaseConfig; | |
| import oxlintResolvedConfig from '@willbooster/oxlint-config'; |
References
- Simplify code as much as possible to eliminate redundancy. (link)
No description provided.