-
Notifications
You must be signed in to change notification settings - Fork 0
chore: willboosterify this repo #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -40,3 +40,5 @@ | |||||
| - Avoid stating what can be easily understood from the code itself. | ||||||
| - Prefer `undefined` over `null` unless explicitly required by APIs or libraries. | ||||||
| - Prefer using a single template literal for prompts instead of `join()` with an array of strings. | ||||||
| - Assume that all environment variables are properly defined. | ||||||
| - If validation is required, use `assert` to fail fast (e.g., during startup). | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using the Node.js
Suggested change
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -40,3 +40,5 @@ | |||||
| - Avoid stating what can be easily understood from the code itself. | ||||||
| - Prefer `undefined` over `null` unless explicitly required by APIs or libraries. | ||||||
| - Prefer using a single template literal for prompts instead of `join()` with an array of strings. | ||||||
| - Assume that all environment variables are properly defined. | ||||||
| - If validation is required, use `assert` to fail fast (e.g., during startup). | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using the Node.js
Suggested change
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -40,3 +40,5 @@ | |||||
| - Avoid stating what can be easily understood from the code itself. | ||||||
| - Prefer `undefined` over `null` unless explicitly required by APIs or libraries. | ||||||
| - Prefer using a single template literal for prompts instead of `join()` with an array of strings. | ||||||
| - Assume that all environment variables are properly defined. | ||||||
| - If validation is required, use `assert` to fail fast (e.g., during startup). | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using the Node.js
Suggested change
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the Node.js
assertmodule for validation is problematic in a React library intended for the browser, as it will cause bundling issues or runtime errors. Consider recommending a more portable approach, such as throwing a standardErrorto fail fast.