Skip to content

chore: willboosterify this repo#19

Merged
WillBooster-bot merged 1 commit intomainfrom
wbfy
May 2, 2026
Merged

chore: willboosterify this repo#19
WillBooster-bot merged 1 commit intomainfrom
wbfy

Conversation

@WillBooster-bot
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the lefthook configuration and pre-push scripts to use the wb tool, simplifying the pre-commit logic and removing manual linting and formatting steps. It also updates several dependencies and removes deprecated scripts from package.json. Feedback suggests further updating the remaining scripts in package.json to use wb for better consistency and to eliminate redundancy across the project.

Comment thread lefthook.yml
if [ -n "$package_json_files" ]; then
node node_modules/.bin/sort-package-json -- $package_json_files
fi
yarn wb lint --fix --format -- {staged_files}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change simplifies the pre-commit hook, for consistency and to fully align with the goal of "willboosterify"-ing the repository, the npm scripts in package.json should also be updated to use wb commands.

Currently, scripts like lint, format, and cleanup still use oxlint and oxfmt directly. This can lead to different behavior between the pre-commit hook and running the scripts manually, which can be confusing for developers.

To complete the migration and eliminate redundancy, consider updating the scripts in package.json. For example:

"scripts": {
  ...
  "cleanup": "yarn wb lint --fix --format .",
  "format": "sort-package-json && yarn wb format .",
  "format-code": "yarn wb format .",
  "lint": "yarn wb lint .",
  "lint-fix": "yarn wb lint --fix .",
  ...
}

(Note: The exact commands for wb might need to be verified.)

References
  1. The repository style guide recommends simplifying code to eliminate redundancy. Having different tools for the same task in git hooks and npm scripts introduces redundancy and inconsistency. (link)

@WillBooster-bot WillBooster-bot merged commit 9cb3659 into main May 2, 2026
11 checks passed
@WillBooster-bot WillBooster-bot deleted the wbfy branch May 2, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant