chore: willboosterify this repo#21
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the @willbooster/wb dependency to version 13.12.13 and introduces specific comment markers in the configuration files for oxfmt and oxlint. Additionally, a variable was renamed in oxlint.config.ts for clarity. The review feedback suggests simplifying both configuration files by using single-line re-exports to eliminate redundancy and align with the repository's coding standards.
| // wbfy:start oxfmt-base | ||
| import config from '@willbooster/oxfmt-config'; | ||
| // wbfy:end oxfmt-base | ||
|
|
||
| // wbfy:start oxfmt-export | ||
| export default config; | ||
| // wbfy:end oxfmt-export |
There was a problem hiding this comment.
This file consists of an import and an immediate default export. This can be simplified to a single re-export line, which is more concise and aligns with our style guide's emphasis on eliminating redundancy.
| // wbfy:start oxfmt-base | |
| import config from '@willbooster/oxfmt-config'; | |
| // wbfy:end oxfmt-base | |
| // wbfy:start oxfmt-export | |
| export default config; | |
| // wbfy:end oxfmt-export | |
| export { default } from '@willbooster/oxfmt-config'; |
References
- Simplify code as much as possible to eliminate redundancy. (link)
| // wbfy:start oxlint-base | ||
| import config from '@willbooster/oxlint-config'; | ||
| import oxlintResolvedConfig from '@willbooster/oxlint-config'; | ||
| // wbfy:end oxlint-base | ||
|
|
||
| // wbfy:start oxlint-export | ||
| export default config; | ||
| export default oxlintResolvedConfig; | ||
| // wbfy:end oxlint-export |
There was a problem hiding this comment.
While renaming config to oxlintResolvedConfig improves clarity, this entire file can be simplified to a single re-export line. This would be more concise and align with our style guide's emphasis on simplicity and eliminating redundancy.
| // wbfy:start oxlint-base | |
| import config from '@willbooster/oxlint-config'; | |
| import oxlintResolvedConfig from '@willbooster/oxlint-config'; | |
| // wbfy:end oxlint-base | |
| // wbfy:start oxlint-export | |
| export default config; | |
| export default oxlintResolvedConfig; | |
| // wbfy:end oxlint-export | |
| export { default } from '@willbooster/oxlint-config'; |
References
- Simplify code as much as possible to eliminate redundancy. (link)
No description provided.