Skip to content

chore: willboosterify this repo#21

Merged
WillBooster-bot merged 1 commit intomainfrom
wbfy
May 4, 2026
Merged

chore: willboosterify this repo#21
WillBooster-bot merged 1 commit intomainfrom
wbfy

Conversation

@WillBooster-bot
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @willbooster/wb dependency to version 13.12.13 and introduces specific comment markers in the configuration files for oxfmt and oxlint. Additionally, a variable was renamed in oxlint.config.ts for clarity. The review feedback suggests simplifying both configuration files by using single-line re-exports to eliminate redundancy and align with the repository's coding standards.

Comment thread oxfmt.config.ts
Comment on lines +1 to +7
// wbfy:start oxfmt-base
import config from '@willbooster/oxfmt-config';
// wbfy:end oxfmt-base

// wbfy:start oxfmt-export
export default config;
// wbfy:end oxfmt-export
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file consists of an import and an immediate default export. This can be simplified to a single re-export line, which is more concise and aligns with our style guide's emphasis on eliminating redundancy.

Suggested change
// wbfy:start oxfmt-base
import config from '@willbooster/oxfmt-config';
// wbfy:end oxfmt-base
// wbfy:start oxfmt-export
export default config;
// wbfy:end oxfmt-export
export { default } from '@willbooster/oxfmt-config';
References
  1. Simplify code as much as possible to eliminate redundancy. (link)

Comment thread oxlint.config.ts
Comment on lines 1 to 7
// wbfy:start oxlint-base
import config from '@willbooster/oxlint-config';
import oxlintResolvedConfig from '@willbooster/oxlint-config';
// wbfy:end oxlint-base

// wbfy:start oxlint-export
export default config;
export default oxlintResolvedConfig;
// wbfy:end oxlint-export
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While renaming config to oxlintResolvedConfig improves clarity, this entire file can be simplified to a single re-export line. This would be more concise and align with our style guide's emphasis on simplicity and eliminating redundancy.

Suggested change
// wbfy:start oxlint-base
import config from '@willbooster/oxlint-config';
import oxlintResolvedConfig from '@willbooster/oxlint-config';
// wbfy:end oxlint-base
// wbfy:start oxlint-export
export default config;
export default oxlintResolvedConfig;
// wbfy:end oxlint-export
export { default } from '@willbooster/oxlint-config';
References
  1. Simplify code as much as possible to eliminate redundancy. (link)

@WillBooster-bot WillBooster-bot merged commit c87f08a into main May 4, 2026
11 checks passed
@WillBooster-bot WillBooster-bot deleted the wbfy branch May 4, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant