Skip to content

fix: avoid duplicate oxlint in verify#740

Merged
exKAZUu merged 6 commits intomainfrom
investigate-wb-verify-oxlint
May 1, 2026
Merged

fix: avoid duplicate oxlint in verify#740
exKAZUu merged 6 commits intomainfrom
investigate-wb-verify-oxlint

Conversation

@exKAZUu
Copy link
Copy Markdown
Member

@exKAZUu exKAZUu commented May 1, 2026

Summary

  • make wb lint --format schedule formatter commands without normal lint checks
  • keep wb lint --fix --format as cleanup mode by running formatters first, then lint fixers
  • update wb verify to call the combined cleanup path once instead of separate format and lint-fix passes
  • simplify linter/formatter command scheduling after review feedback

Why

  • wb verify --full previously ran plain oxlint during the format pass, then ran oxlint --fix during lint-fix
  • separating formatter and linter phases keeps wb lint, wb lint --format, and wb lint --fix --format behavior predictable while preserving existing cleanup workflows

Testing

  • yarn verify
  • yarn workspace @willbooster/wb typecheck
  • yarn workspace @willbooster/wb test
  • yarn workspace @willbooster/wb start --working-dir "$PWD" verify --full --dry-run --verbose

Review

  • CI passed on the latest commit
  • all review threads resolved

Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the linting and formatting logic to separate commands into distinct linter and formatter categories, allowing for more granular control over execution. It introduces the LintRunCommand interface and helper functions like runLintCommands to streamline command execution. Feedback was provided to merge redundant loops when populating command lists for different project types and to consolidate multiple iterations over project descendants into a single loop to improve maintainability and reduce code redundancy.

Comment thread packages/wb/src/commands/lint.ts
Comment thread packages/wb/src/commands/lint.ts Outdated
exKAZUu and others added 3 commits May 2, 2026 08:13
… loop

Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu
Copy link
Copy Markdown
Member Author

exKAZUu commented May 1, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the linting and formatting logic to separate these concerns into distinct command sets. It introduces LintRunCommand and runLintCommands to handle parallel execution of formatters and linters independently, and splits language-specific commands (Poetry, Dart) into separate lint and format functions. In packages/wb/src/commands/lint.ts, there is an opportunity to merge consecutive shouldRunLinters blocks to reduce redundancy and improve readability.

Comment thread packages/wb/src/commands/lint.ts Outdated
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu
Copy link
Copy Markdown
Member Author

exKAZUu commented May 1, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the linting and formatting logic to separate these concerns, introducing distinct commands for each and improving the execution flow. The changes include splitting buildPoetryCommand and buildDartCommand into separate lint and format functions, and updating the lint command to handle formatters and linters independently. Feedback was provided to simplify boolean logic and redundant type conversions for better readability.

Comment thread packages/wb/src/commands/lint.ts Outdated
Comment thread packages/wb/src/commands/lint.ts Outdated
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu
Copy link
Copy Markdown
Member Author

exKAZUu commented May 1, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the linting and formatting logic within the wb package by separating the generation and execution of formatter and linter commands. Key changes include splitting the Poetry and Dart command builders into distinct format and lint functions, and updating the lint command to execute formatters before linters with an early exit if formatting fails. Additionally, the verifyCode command was simplified by consolidating formatting and lint-fixing into a single cleanup step. I have no feedback to provide.

@exKAZUu exKAZUu merged commit 9b9039f into main May 1, 2026
6 checks passed
@exKAZUu exKAZUu deleted the investigate-wb-verify-oxlint branch May 1, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant