Skip to content

chore: willboosterify this repo#741

Merged
WillBooster-bot merged 1 commit intomainfrom
wbfy
May 2, 2026
Merged

chore: willboosterify this repo#741
WillBooster-bot merged 1 commit intomainfrom
wbfy

Conversation

@WillBooster-bot
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates @willbooster/wb and build-ts dependencies across multiple packages and removes the check-all-for-ai and check-for-ai scripts. Feedback indicates that the yarn.lock file incorrectly includes win32 platform entries, violating the repository's policy to drop Windows support. Furthermore, a version mismatch for @typescript/native-preview between package.json and the updated build-ts dependency should be resolved to eliminate redundancy in the lockfile.

Comment thread yarn.lock
version: 7.0.0-dev.20260420.1
resolution: "@typescript/native-preview-win32-x64@npm:7.0.0-dev.20260420.1"
conditions: os=win32 & cpu=x64
"@typescript/native-preview-win32-arm64@npm:7.0.0-dev.20260426.1":
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lockfile contains entries for win32 platforms (e.g., @typescript/native-preview-win32-arm64). This violates the repository style guide which states that Windows support should be dropped. Please configure supportedArchitectures in .yarnrc.yml to exclude win32 and regenerate the lockfile.

References
  1. Always drop any Windows support. (link)

Comment thread yarn.lock
"@typescript/native-preview@npm:7.0.0-dev.20260421.2":
version: 7.0.0-dev.20260421.2
resolution: "@typescript/native-preview@npm:7.0.0-dev.20260421.2"
"@typescript/native-preview@npm:7.0.0-dev.20260426.1":
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PR introduces @typescript/native-preview@7.0.0-dev.20260426.1 as a dependency of build-ts@17.1.9, but the project's package.json files still pin it to 7.0.0-dev.20260421.2. This results in multiple versions of this native package in the lockfile. Please update the version in all package.json files to 7.0.0-dev.20260426.1 to eliminate redundancy.

References
  1. Simplify code as much as possible to eliminate redundancy. (link)

@WillBooster-bot WillBooster-bot merged commit ce1eda2 into main May 2, 2026
10 checks passed
@WillBooster-bot WillBooster-bot deleted the wbfy branch May 2, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant