Skip to content

fix: pass mise age key to docker builds#744

Merged
exKAZUu merged 1 commit intomainfrom
fix/wb-pass-mise-age-key
May 4, 2026
Merged

fix: pass mise age key to docker builds#744
exKAZUu merged 1 commit intomainfrom
fix/wb-pass-mise-age-key

Conversation

@exKAZUu
Copy link
Copy Markdown
Member

@exKAZUu exKAZUu commented May 4, 2026

Summary

  • pass MISE_AGE_KEY into generated docker build commands as a BuildKit secret when it is defined
  • keep the existing Dockerfile-facing secret id as mise_age_key

Verification

  • yarn verify

@exKAZUu @WillBooster-Agent
fix: pass mise age key to docker builds
db722d6 
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu exKAZUu enabled auto-merge (squash) May 4, 2026 04:16
@exKAZUu exKAZUu disabled auto-merge May 4, 2026 04:17
@exKAZUu exKAZUu merged commit 9dcfe5e into main May 4, 2026
7 checks passed
@exKAZUu exKAZUu deleted the fix/wb-pass-mise-age-key branch May 4, 2026 04:17
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Docker build command in dockerScripts.ts to conditionally include a --secret flag for MISE_AGE_KEY when the environment variable is defined. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@exKAZUu