Skip to content

fix: clarify managed oxfmt config generation#746

Merged
exKAZUu merged 5 commits intomainfrom
fix-specific-tool-config-content
May 4, 2026
Merged

fix: clarify managed oxfmt config generation#746
exKAZUu merged 5 commits intomainfrom
fix-specific-tool-config-content

Conversation

@exKAZUu
Copy link
Copy Markdown
Member

@exKAZUu exKAZUu commented May 4, 2026

Summary

  • Replace the ambiguous generic tool config content generator with oxfmt-specific config generation in oxfmtConfig.ts
  • Add wbfy managed oxfmt-base and oxfmt-export markers to generated oxfmt configs, matching the oxlint config update pattern
  • Extract shared managed-block replacement behavior into ManagedConfigBlocks and reuse it from both oxfmt and oxlint generators
  • Keep generated CommonJS oxfmt wording specific to oxfmt .ts auto-discovery

Why

  • The old generateToolConfigContent name implied broader tool support than it actually provided
  • Oxfmt config should preserve user-owned content around managed sections the same way oxlint config does
  • A small class removes repeated marker/tool arguments while keeping tool-specific behavior explicit at each generator

Testing

  • yarn verify

Notes

  • yarn verify still reports four existing unrelated oxlint warnings in packages/wbfy; no new warnings or errors were introduced

exKAZUu and others added 3 commits May 4, 2026 13:52
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the configuration generation logic by replacing the generic toolConfigContent.ts with a specialized oxfmtConfigContent.ts and a shared configContent.ts for content normalization. It updates the oxfmtConfig and oxlintConfig generators to utilize these new modules, improving modularity. I have no feedback to provide.

exKAZUu and others added 2 commits May 4, 2026 14:00
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu exKAZUu changed the title fix: clarify oxfmt config content generation fix: clarify managed oxfmt config generation May 4, 2026
@exKAZUu exKAZUu merged commit 16304c2 into main May 4, 2026
7 checks passed
@exKAZUu exKAZUu deleted the fix-specific-tool-config-content branch May 4, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant