fix: clarify managed oxfmt config generation#746
Merged
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the configuration generation logic by replacing the generic toolConfigContent.ts with a specialized oxfmtConfigContent.ts and a shared configContent.ts for content normalization. It updates the oxfmtConfig and oxlintConfig generators to utilize these new modules, improving modularity. I have no feedback to provide.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxfmtConfig.tswbfymanagedoxfmt-baseandoxfmt-exportmarkers to generated oxfmt configs, matching the oxlint config update patternManagedConfigBlocksand reuse it from both oxfmt and oxlint generators.tsauto-discoveryWhy
generateToolConfigContentname implied broader tool support than it actually providedTesting
yarn verifyNotes
yarn verifystill reports four existing unrelated oxlint warnings inpackages/wbfy; no new warnings or errors were introduced