Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a quiet-env option to suppress environment variable loading information and enhances the runWithSpawn utility to support silent progress indicators and success messages. It also refactors unit test execution to utilize these new silent output features. A review comment identifies a logic issue in sharedOptionsBuilder.ts where the --quiet-env flag could be incorrectly appended even if explicitly disabled by the user, and provides a code suggestion to fix it.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces features to suppress and manage console output during environment variable loading and command execution. Key changes include the addition of a quiet-env flag, a utility to determine when to suppress environment-related logs, and enhancements to runWithSpawn to support silent progress intervals, success messages, and failure-only output printing. Unit tests have been updated to use these new silent execution options for a cleaner CLI experience. Additionally, @types/* was added to the package list in the yarnrc generator. I have no feedback to provide.
Summary
wb test --silentwhile printing a.progress marker every 10 secondsquiet-envsupport and propagate it to nestedwbcommands without overriding explicit--quiet-env=false@types/*packages in generated Yarn config so managed type dependencies are not blocked bynpmMinimalAgeGateWhy
wbfygenerated projects can otherwise fail cleanup when a freshly published@types/*version is selected and Yarn quarantines it.Testing
yarn workspace @willbooster/wb start test --silentnode packages/wb/bin/index.js test --silent --dry-runyarn workspace @willbooster/wbfy test test/cleanupIdempotency.test.tsyarn verifybunx @willbooster/agent-skills@latest review --agent allbunx @willbooster/agent-skills@latest check-pr-ciNotes
yarn testrun hit an unrelated@willbooster/shared-lib-nodeSIGTERM/killOnExit timeout on macOS; the CI test workflow passed after thewbfyfix.