Skip to content

fix: reduce silent test output#753

Merged
exKAZUu merged 5 commits intomainfrom
fix/wb-test-silent-unit-output
May 8, 2026
Merged

fix: reduce silent test output#753
exKAZUu merged 5 commits intomainfrom
fix/wb-test-silent-unit-output

Conversation

@exKAZUu
Copy link
Copy Markdown
Member

@exKAZUu exKAZUu commented May 8, 2026

Summary

  • suppress successful unit test output in wb test --silent while printing a . progress marker every 10 seconds
  • print buffered unit test output only when the unit test command fails
  • add quiet-env support and propagate it to nested wb commands without overriding explicit --quiet-env=false
  • preapprove @types/* packages in generated Yarn config so managed type dependencies are not blocked by npmMinimalAgeGate

Why

  • Silent test runs should stay quiet for short unit test phases while still showing liveness for longer runs.
  • Failed unit tests still need the full buffered output for debugging.
  • Environment-loading logs should be suppressible during silent runs, but explicit user preferences must remain authoritative.
  • wbfy generated projects can otherwise fail cleanup when a freshly published @types/* version is selected and Yarn quarantines it.

Testing

  • yarn workspace @willbooster/wb start test --silent
  • node packages/wb/bin/index.js test --silent --dry-run
  • yarn workspace @willbooster/wbfy test test/cleanupIdempotency.test.ts
  • yarn verify
  • bunx @willbooster/agent-skills@latest review --agent all
  • bunx @willbooster/agent-skills@latest check-pr-ci

Notes

  • A local full yarn test run hit an unrelated @willbooster/shared-lib-node SIGTERM/killOnExit timeout on macOS; the CI test workflow passed after the wbfy fix.

Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a quiet-env option to suppress environment variable loading information and enhances the runWithSpawn utility to support silent progress indicators and success messages. It also refactors unit test execution to utilize these new silent output features. A review comment identifies a logic issue in sharedOptionsBuilder.ts where the --quiet-env flag could be incorrectly appended even if explicitly disabled by the user, and provides a code suggestion to fix it.

Comment thread packages/wb/src/sharedOptionsBuilder.ts Outdated
exKAZUu and others added 4 commits May 8, 2026 23:48
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu
Copy link
Copy Markdown
Member Author

exKAZUu commented May 8, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces features to suppress and manage console output during environment variable loading and command execution. Key changes include the addition of a quiet-env flag, a utility to determine when to suppress environment-related logs, and enhancements to runWithSpawn to support silent progress intervals, success messages, and failure-only output printing. Unit tests have been updated to use these new silent execution options for a cleaner CLI experience. Additionally, @types/* was added to the package list in the yarnrc generator. I have no feedback to provide.

@exKAZUu exKAZUu changed the title fix: reduce silent unit test output fix: reduce silent test output May 8, 2026
@exKAZUu exKAZUu merged commit 58a05d9 into main May 8, 2026
7 checks passed
@exKAZUu exKAZUu deleted the fix/wb-test-silent-unit-output branch May 8, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant