chore: willboosterify this repo#754
Open
WillBooster-bot wants to merge 1 commit intomainfrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the @willbooster/wb dependency to version 13.12.14 across the monorepo, adds @types/* to the preapproved packages in .yarnrc.yml, and refactors Oxlint configurations to properly handle root-only options in package-local files. Feedback was provided to simplify the root Oxlint configuration by removing a redundant variable assignment and importing the base configuration directly with the desired name.
Comment on lines
+2
to
+4
| import oxlintBaseConfig from '@willbooster/oxlint-config'; | ||
|
|
||
| const oxlintResolvedConfig = oxlintBaseConfig; |
Contributor
There was a problem hiding this comment.
This assignment is redundant. You can simplify the code by importing the configuration directly with the desired name, adhering to the rule of eliminating redundancy.
Suggested change
| import oxlintBaseConfig from '@willbooster/oxlint-config'; | |
| const oxlintResolvedConfig = oxlintBaseConfig; | |
| import oxlintResolvedConfig from '@willbooster/oxlint-config'; |
References
- Simplify code as much as possible to eliminate redundancy. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.